This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Adds a session getter to historical proofs #5125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
approved these changes
Mar 4, 2020
rphmeier
added
A7-looksgoodtestsfail
and removed
A0-please_review
Contributor
|
cc @gnunicorn this is technically a breaking change, should we wait to merge? Something that's definitely needed for slashing. |
Contributor
|
we are still in alpha-release-phase, we are accepting not-too-involved breaking changes. |
Contributor
Author
|
Also added some trait derives that are necessary for using the |
Contributor
|
failing test, merge conflict. |
NikVolf
approved these changes
Mar 5, 2020
Contributor
Author
|
@gnunicorn can we now get this in? |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 6, 2020
* Adds a session getter to historical proofs * Bump spec_version * Adds some useful trait derives to Proof
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
* Adds a session getter to historical proofs * Bump spec_version * Adds some useful trait derives to Proof
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a session getter for
session::historical::Proof. It is needed for offence handlers such as paritytech/polkadot#840 to determine the exact session of the commited equivocation and create the correspondingOffencestruct.